WASM modules which export more than 1 symbol provide invalid code - Githubissues

JasonBock / WebAssembly.Generators

Source generators for the WebAssembly package.

MIT License

1 stars 1 forks source link

WASM modules which export more than 1 symbol provide invalid code #10

Closed Silic0nS0ldier closed 3 years ago

Silic0nS0ldier commented 3 years ago

Import dictionary entries aren't separated with commas, resulting in invalid syntax.

https://github.com/JasonBock/WebAssembly.Generators/blob/2aa4cd990bb59c36ed4722a6b30208bddf8cc1d5/src/WebAssembly.Generators/WasmExportBuilder.cs#L103

e.g. (source from https://github.com/GoogleChromeLabs/squoosh/tree/5595525c8a7d0020f55fac069b3de851b06a3168/codecs/jxl/dec)

<AdditionalFiles Include="jxl_dec.wasm" ClassName="Decode" Namespace="JpegXl" />
<AdditionalFiles Include="jxl_node_dec.wasm" ClassName="NodeDecode" Namespace="JpegXl" />

JasonBock commented 3 years ago

Whoops :(. That's definitely a problem, but hopefully it should be easy to fix. No guarantees on a timeline, but I will get to it when I can.