search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
64 stars 9 forks source link

Fix dependencies path and issues with secure boot key #100

Closed JasonN3 closed 7 months ago

JasonN3 commented 7 months ago

/run build container

noelmiller commented 7 months ago

Looks like most everything is working on this branch except a few things:

  1. Make Targets seem to not work properly, see https://github.com/ublue-os/bluefin/actions/runs/8583351116/job/23522456937 for details. I commented out the code to test other functionality. UPDATE: Gonna open a separate issue for resolving this. This already has too many things being changed for 1 PR.
  2. Secure Boot is broken, it is not copying over sb_pubkey.der in the xorriso step, opened issue: https://github.com/JasonN3/build-container-installer/issues/102
noelmiller commented 7 months ago

/run tests

noelmiller commented 7 months ago

Fixes: #102 and issues with flatpak dependencies.

noelmiller commented 7 months ago

Interesting, still broken in Bazzite. I'm gonna do more debugging and see where it's dropping the file.. https://github.com/ublue-os/bazzite/actions/runs/8605449983/job/23581734802

UPDATE: This is because when I'm building the container, it is not pushing it with the deps tag. It's no big deal, I can test this after it's merged into main.

noelmiller commented 7 months ago

/run build container

noelmiller commented 7 months ago

Get Job URL is task if failing inconsistently now. Like, sometimes the jobs are firing off and other times they get held up by that. At any rate, I feel pretty confident we can merge this regarding of some failing tests. I can open a separate issue if you'd like for the failing tests issue. I've tried 3 times to fire off with my changes I made and it's been getting some of them to go each time: https://github.com/JasonN3/build-container-installer/actions/runs/8605801976/job/23588354201

JasonN3 commented 7 months ago

@noelmiller, you need to fix the Codacy issue

JasonN3 commented 7 months ago

Once that's fixed, I can merge it since the separate run (https://github.com/JasonN3/build-container-installer/actions/runs/8608830718) passed all the tests.

JasonN3 commented 7 months ago

/run tests

JasonN3 commented 7 months ago

Passing tests at https://github.com/JasonN3/build-container-installer/actions/runs/8616695515/job/23615920632 There are currently too many jobs for the bot commands to work. Per-page is increased in this PR to allow future PRs to pass