JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
50 stars 9 forks source link

[FR] Support for creating online ISOs #101

Open fiftydinar opened 5 months ago

fiftydinar commented 5 months ago

Intro

This issue is made in order to track the state of online ISOs implementation in build-container-installer.

There are some users who prefer to have or offer online ISOs for the images, including me, so here is the list of advantages & disadvantages of online ISOs over offline ones that I gathered.

Advantages

Disadvantages

Some of those Anaconda issues are fixed in offline ISOs, like the last 2 ones, so maybe those can be used in online ISOs too.

noelmiller commented 5 months ago

I would recommend against implementing this. The reason we never added it back in when running our fork was because of the amount of issues that would come from users installing from an online ISO.

Until Anaconda is able to implement retries or better logging for online installation, I would never use this tool to create online ISOs even if the feature exists.

JasonN3 commented 5 months ago

What about a %pre script that runs the skopeo copy command right before it tries to install? It can be wrapped with a while or for loop to retry if it fails to download.

noelmiller commented 5 months ago

What about a %pre script that runs the skopeo copy command right before it tries to install? It can be wrapped with a while or for loop to retry if it fails to download.

It has to be better than the current kickstart option that is provided by anaconda. We originally used that and it doesn't have retries. Might be something to consider pushing upstream to them as an actual fix?

JasonN3 commented 5 months ago

What about a %pre script that runs the skopeo copy command right before it tries to install? It can be wrapped with a while or for loop to retry if it fails to download.

It has to be better than the current kickstart option that is provided by anaconda. We originally used that and it doesn't have retries. Might be something to consider pushing upstream to them as an actual fix?

Anything we put in here wouldn't be compatible with Anaconda's code. We could use it to test a concept and possibly even write some python code that could be modified to fit in Anaconda, but nothing would be a straight 1-1 since the goal is to not modify Anaconda wherever possible.

noelmiller commented 5 months ago

What about a %pre script that runs the skopeo copy command right before it tries to install? It can be wrapped with a while or for loop to retry if it fails to download.

It has to be better than the current kickstart option that is provided by anaconda. We originally used that and it doesn't have retries. Might be something to consider pushing upstream to them as an actual fix?

Anything we put in here wouldn't be compatible with Anaconda's code. We could use it to test a concept and possibly even write some python code that could be modified to fit in Anaconda, but nothing would be a straight 1-1 since the goal is to not modify Anaconda wherever possible.

For sure, I suppose I meant more reliable in functionality than anything else.

github-actions[bot] commented 3 months ago

Issue is stale and will be closed in 14 days if there is no further activity

fiftydinar commented 3 months ago

bump

github-actions[bot] commented 1 month ago

Issue is stale and will be closed in 14 days if there is no further activity

oomfiee commented 1 month ago

bump