search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
64 stars 9 forks source link

[FR] Write Test to Check Secure Boot Key is loaded if one is provided #103

Closed noelmiller closed 5 months ago

noelmiller commented 7 months ago

Is your feature request related to a problem? Please describe. There was a recent reorganization of the monolithic make file into smaller make files. Upon doing this, secure boot key was not getting copied over properly and we had no tests to confirm that it was broken.

Describe the solution you'd like We need to have a test that does not have a secure boot key and one that does. All of our tests currently have the secure boot key by default.

We would create a VM test that would check any of the VMs with a secure boot key loaded that it loaded the proper key onto the VM. mokutil --list-enrolled gets a list of keys. We could do a grep on the entire public key to make sure it appears in there.

Additional context Issue was found here: https://github.com/JasonN3/build-container-installer/pull/100

noelmiller commented 7 months ago

Thinking on this a bit more, we actually would need to somehow automate going through the mokutil process for enrolling the key with a password. That is a bit more involved and I'm not sure how I would accomplish that in an automated fashion.

github-actions[bot] commented 5 months ago

Issue is stale and will be closed in 14 days if there is no further activity