search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
64 stars 9 forks source link

[BUG] Cannot install more than one flatpak when running from container #60

Closed noelmiller closed 8 months ago

noelmiller commented 8 months ago

Describe the bug You cannot install multiple flatpak packages when using the docker command.

To Reproduce docker run --rm --privileged --volume .:/github/workspace/build ghcr.io/jasonn3/build-container-installer:latest VERSION=39 IMAGE_NAME=bluefin IMAGE_REPO=ghcr.io/ublue-os IMAGE_TAG=39-testing VARIANT=Silverblue FLATPAK_REMOTE_REFS="app/org.videolan.VLC/x86_64/stable runtime/org.kde.Platform/x86_64/5.15-23.08"

Expected behavior Export the variables properly

Output

+ for entry in $@
+ export VERSION=39
+ VERSION=39
+ for entry in $@
+ export IMAGE_NAME=bluefin
+ IMAGE_NAME=bluefin
+ for entry in $@
+ export IMAGE_REPO=ghcr.io/ublue-os
+ IMAGE_REPO=ghcr.io/ublue-os
+ for entry in $@
+ export IMAGE_TAG=39-testing
+ IMAGE_TAG=39-testing
+ for entry in $@
+ export VARIANT=Silverblue
+ VARIANT=Silverblue
+ for entry in $@
+ export FLATPAK_REMOTE_REFS=app/org.videolan.VLC/x86_64/stable
+ FLATPAK_REMOTE_REFS=app/org.videolan.VLC/x86_64/stable
+ for entry in $@
+ export runtime/org.kde.Platform/x86_64/5.15-23.08
/entrypoint.sh: line 7: export: `runtime/org.kde.Platform/x86_64/5.15-23.08': not a valid identifier
JasonN3 commented 8 months ago

Put quotes around the list of flatpaks. https://github.com/JasonN3/build-container-installer/blob/df936e3365f994db4e5e0683d7e3cd97b9f37768/action.yml#L159

noelmiller commented 8 months ago

Put quotes around the list of flatpaks. https://github.com/JasonN3/build-container-installer/blob/df936e3365f994db4e5e0683d7e3cd97b9f37768/action.yml#L159

There are quotes around the list of flatpaks in my example command. Receive the error with single quotes and double quotes.

To be clear, this is running the docker command on my desktop for testing and not running it as part of the action.

JasonN3 commented 8 months ago

The action calls docker run. It works just fine there and someone mentioned in Discord that they built it with VLC, which requires 2 flatpaks. I also just looked at your command. Use main not latest

noelmiller commented 8 months ago

The action calls docker run. It works just fine there and someone mentioned in Discord that they built it with VLC, which requires 2 flatpaks. I also just looked at your command. Use main not latest

That was the issue. latest is tied to the latest version and not main. Command is running properly.