JaxkDev / koth

King Of The Hill, Pocketmine-MP Mini-game Plugin.
https://tiny.cc/JaxksDC
GNU General Public License v3.0
9 stars 3 forks source link

On server restart error, world no longer exist #15

Closed jasin closed 5 years ago

jasin commented 5 years ago

As the title states, using multiworld setting up a KOTH arena works fine, but on server restart it says that the arena has been setup in a world that no longer exist. Which isn't the case. I've checked the db and the entry looks good.

JaxkDev commented 5 years ago

Please try the latest commit (you will have to either compile yourself or use devtools) and let me know if it fixes it.

JaxkDev commented 5 years ago

Probably dupe of #9

jasin commented 5 years ago

what commit fixed #9

JaxkDev commented 5 years ago

6ba20bf

jasin commented 5 years ago

commit 6ba20bf3d7ed8f6f73e4e5850247c643512a787a (HEAD -> development, origin/development)

bug still exist I deleted the db entry using koth rem I created the arena I joined the arena I restarted the server I tried joining again and the error pops up

JaxkDev commented 5 years ago

i need the whole server log (with koth debug enabled) please.

jasin commented 5 years ago

to keep this clean I up'd to pastebin

https://pastebin.com/mZLftH1Y

last edit is the last restarts of the server showing the koth events I listed above

JaxkDev commented 5 years ago

It doesn’t show any errors so it’s not koth stopping the server, I’m almost certain it’s missing a lot of debug messages as well will read it properly later.

jasin commented 5 years ago

the server crashing isn't the issue. the problem is after server restart koth join gives an error that the world no longer exist where the arena was setup. This is certainly not the case, since I can teleport to that world. the issue is directly related to a server restart.

JaxkDev commented 5 years ago

2 Things, One is that debug/log is missing vital information it should contain something like:

[16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Provider was set to: Yaml [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Arena data file opened. [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Checking status in arena 'test', save: yes [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Setting status to 'Ready'. (Arena: 'test') [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Creating KT particle for arena 'test' [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Checking status in arena 'test', save: yes [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Setting status to 'Ready'. (Arena: 'test') [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : KT Particle being created... ('test') [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : test - Arena Constructed, status: Ready [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : 1 Arena(s) loaded. [16:06:13] [Server thread/INFO]: [KOTH | DEBUG] : Starting update check task...

and secondly your not restarting server but reloading.

so can you get that part of the log, and try it without restarting server.

jasin commented 5 years ago

2 things.

The debug output is exactly what I get when setting debug: true in config.yml if it is missing something then it is not something I have done. tell me what i need to change and I will.

Secondly, the issue is ONLY related to server restart. After a server restart when the command koth join is called there is an error that pops up that says "[KOTH] the place that arena was setup no longer exist." this is repeatable over and over and over again.

JaxkDev commented 5 years ago

Use the developments branch latest commit, that’s all from beta3/early beta4. It’s highly likely this is linked to a previously issue.

jasin commented 5 years ago

Is this not the latest commit?

/home/pocketmine/pocketmine-mp/plugins/koth$ git show
commit 6ba20bf3d7ed8f6f73e4e5850247c643512a787a (HEAD -> development, origin/development)
JaxkDev commented 5 years ago

It is, but the log and error message you sent got changed in beta4 so I’m almost certain it’s not running beta4 or the log/message you sent is outdated.

jasin commented 5 years ago

the log file showed I am running the development branch, line 340

2019-10-01 [16:13:08] [Server thread/INFO]: Enabling KOTH v1.0.0-Beta4

JaxkDev commented 5 years ago

If you’re certain it’s running the dev branch please do all of the following:

jasin commented 5 years ago

sql dump https://pastebin.com/zF4QqESA

server.log, ls worlds dir, mw list https://pastebin.com/K5tZWvNE

you can see the commands I ran. I'm not fudging anything, its c&p from the output

jasin commented 5 years ago

Line 136 - 139 is where I am creating the arena and then teleporting back to hub. then I join the areana using

/koth join koth_phoenix

all works. I stop the server from console and restart the server.

koth join koth_phoenix again and error

[KOTH] the place where that arena was setup no longer exist

and it certainly does exist and git doesn't lie

/home/pocketmine/pocketmine-mp/plugins/koth$ git branch
* development
  master
JaxkDev commented 5 years ago

From that SQLite file I can confirm that is not the beta4 with all the fixes. It has a bug I fixed in that commit and is impossible to reproduce without modifying code.

jasin commented 5 years ago

You can see I only have your git repo installed. git branch says I am using development. What else do you expect me to do? I'm game to figure out what the deal is, but I know of nothing else I can do. I'm running git development from your cloned repo. You tell me I'm not yet everything I have showed you proves I am besides the sqlite dump. Somewhere there is an issue, but i'm not new to this

/home/pocketmine/pocketmine-mp/plugins$ ls -al
total 580
drwxr-xr-x 3 pocketmine pocketmine  4096 Oct  1 16:08 .
drwxrwx--- 9 pocketmine pocketmine  4096 Oct  3 12:01 ..
-rw-r--r-- 1 pocketmine pocketmine  1644 Jun 21  2018 AlwaysSpawn.phar
-rw-r--r-- 1 pocketmine pocketmine  3582 Jul  4 14:11 BlazinFly.phar
-rw-r--r-- 1 pocketmine pocketmine 36172 Jun 21  2018 EconomyAPI.phar
-rw-r--r-- 1 pocketmine pocketmine 16675 Aug 19 22:29 FactionsPro.phar
drwxrwxr-x 6 pocketmine pocketmine  4096 Oct  1 16:05 koth
-rw-r--r-- 1 pocketmine pocketmine  7834 Mar 31  2019 LessIsMore.phar
-rw-r--r-- 1 pocketmine pocketmine 55166 Jun  5 18:59 MultiWorld.phar
-rw-r--r-- 1 pocketmine pocketmine  3771 Apr  6 08:09 OreGen.phar
-rw-r--r-- 1 pocketmine pocketmine  2756 Jul  6  2018 PerWorldChat.phar
-rw-r--r-- 1 pocketmine pocketmine 58922 Jul 14 06:54 PlayerVaults.phar
-rw-r--r-- 1 pocketmine pocketmine 39032 Jun 19 12:40 PocketMine-DevTools.phar
-rw-r--r-- 1 pocketmine pocketmine 10114 Jun 21  2018 PureChat.phar
-rw-r--r-- 1 pocketmine pocketmine 74154 Dec  2  2018 PurePerms.phar
-rw-r--r-- 1 pocketmine pocketmine  4484 Jul  7 10:28 Rewards.phar
-rw-r--r-- 1 pocketmine pocketmine 15520 May  9 01:35 ShopUI-FormAPI-Working.phar
-rw-r--r-- 1 pocketmine pocketmine  9402 Jan  1  2019 SimpleHome.phar
-rw-r--r-- 1 pocketmine pocketmine 52483 Aug 11 21:21 SkyBlock.phar
-rw-r--r-- 1 pocketmine pocketmine 15666 Jun  1 18:35 SkyWars.phar
-rw-r--r-- 1 pocketmine pocketmine  7465 Dec 19  2018 SlapperCache.phar
-rw-r--r-- 1 pocketmine pocketmine 21915 Jul 12 18:28 Slapper.phar
-rw-r--r-- 1 pocketmine pocketmine  1549 Jan  5  2019 SlapperRotation.phar
-rw-r--r-- 1 pocketmine pocketmine 51642 Jul 26 15:06 Texter.phar
-rw-r--r-- 1 pocketmine pocketmine  2680 Jan 27  2019 VanillaCoordinates.phar
-rw-r--r-- 1 pocketmine pocketmine 39436 Jul 31  2018 WorldProtect.phar
-rw-r--r-- 1 pocketmine pocketmine  4938 Aug 23  2018 WorldTP.phar
JaxkDev commented 5 years ago

It’s not just SQLite file that’s shown me it’s not fully beta4.

Listen to me it sounds like your running the commit before. If you want you can try deleting the koth folder, and clone the repo again then git checkout development and send the log you get when loading the arena after server restart but I can’t reproduce the issue so I can’t fix what I can’t see as broken

jasin commented 5 years ago

I have no idea, but I tried a different approach with git and only cloned the development branch and now its definitely running the beta4. The original issue here is gone.

That was painful and horribly agonizing, either git or github to blame here. Sorry

JaxkDev commented 5 years ago

For final reference, duplicate of #9 just had trouble resolving issue.