JdeRobot / RoboticsInfrastructure

Infrastructure for robotic applications
43 stars 39 forks source link

[Humble] Duplicate worlds in the repository #337

Open pawanw17 opened 1 year ago

pawanw17 commented 1 year ago

There exist duplicate worlds inside Worlds directory and CustomRobots/

Tanishq30052002 commented 8 months ago

Hi @pawanw17 , I would like to work on the issue, can i go ahead with it?

pawanw17 commented 8 months ago

Sure please

Tanishq30052002 commented 8 months ago

hey @pawanw17 , In the repo there are different worlds files and different launch files too, so am I supposed to convert them to launch.py format too so it will be compatible with ROS2 also. Also, many more pkgs have the same problem, so could you please clarify it?

pawanw17 commented 8 months ago

Hi @Tanishq30052002, In this repo mainly we have two branches which are actively developed, noetic-devel and humble-devel, inside these you can find .world files which gazebo uses, This issue is only targetting the world files and not the launch files.

Tanishq30052002 commented 8 months ago

Hi @pawanw17 Should I add different world files too in world directory?

pawanw17 commented 8 months ago

What do you mean?

Tanishq30052002 commented 8 months ago

@pawanw17 Since in custom robots there are some more world files which are not duplicate to the ones in the world directory. So I want to know if we are supposed to move those world files to the world directory also?

pawanw17 commented 8 months ago

@jmplaza where should we keep all the world files? inside CustomRobots folder?

That way when CustomRobots is built they would automatically be sourced, but I don't know if other applications(Visualcircuit, btstudio) build CustomRobots.

Tanishq30052002 commented 8 months ago

hi @pawanw17 @jmplaza I would be glad if you could please clear the task.