What is the need of two separate preprocessing files?

Jeff20100601 / GHNN_clean

MIT License

30 stars 6 forks source link

What is the need of two separate preprocessing files? #1

Open tonygracious opened 3 years ago

tonygracious commented 3 years ago

What is need of two separate preprocessing files ? https://github.com/Jeff20100601/GHNN_clean/blob/master/data/GDELT/get_history.py and https://github.com/Jeff20100601/GHNN_clean/blob/master/data/GDELT/get_history_tpre_appro.py. It looks like they share a lot of codes.

tonygracious commented 3 years ago

https://github.com/Jeff20100601/GHNN_clean/blob/df02f049daeb867b3e4607b96e309e373c396d8a/data/GDELT/get_history_tpre_appro.py#L159-L164 These variables are not used anywhere

CaiWZ commented 3 years ago

https://github.com/Jeff20100601/GHNN_clean/blob/df02f049daeb867b3e4607b96e309e373c396d8a/data/GDELT/get_history_tpre_appro.py#L159-L164

These variables are not used anywhere

hello, I find the model uses time interval(time difference) rather than time, I don't know if you have some idea about this. Can you answer this question for me?