JetBrains-Research / pubtrends

Scientific literature explorer. Runs a Pubmed or Semantic Scholar search and allows user to explore high-level structure of result papers
Apache License 2.0
36 stars 2 forks source link

Bad JAR archive path in instructions for Semantic Scholar download #164

Closed ctrltz closed 4 years ago

ctrltz commented 5 years ago

Commands from README.md:

cd <PATH_TO_SEMANTIC_SCHOLAR_ARCHIVE>
wget https://s3-us-west-2.amazonaws.com/ai2-s2-research-public/open-corpus/manifest.txt
cat manifest.txt | grep corpus | while read -r url; do 
   wget https://s3-us-west-2.amazonaws.com/ai2-s2-research-public/open-corpus/$url;
   java -cp build/libs/pubtrends-dev.jar org.jetbrains.bio.pubtrends.ss.MainKt --fillDatabase
   rm $(echo $url | sed -E 's#^.*/##g');
done

When directory is changed to <PATH_TO_SEMANTIC_SCHOLAR_ARCHIVE>, JAR archive might not be available at specified relative path build/libs/pubtrends-dev.jar, which leads to an error.

Also these commands are very convenient, we might consider wrapping them in .sh file. What do you think, @olegs?

olegs commented 5 years ago

I think we should use full path to pubtrends-dev.jar to cope with this problem.

olegs commented 4 years ago

Obsolete.