search

JiaruiJin / API_GoogleCloud

This is the first project of EC601
0 stars 1 forks source link

Code Review #2

Open jyueling opened 6 years ago

jyueling commented 6 years ago 
This project is downloading pictures from certain twitter account, label it by using google vision API and covert these labeled picture to video. From my point of view, the developer handled all the problems and errors that would occur during this project. Also, name of function and files are easy to understand. Due to clear comments of each file, I can easily recognize how each lines are doing for this project.
For improvements, I suggest the developer can add a function to control the number of images. This is because for some twitter account it has a huge number of images, it would take such a long time to download images. Moreover, the video that the project provide does not contain the label of the images. My suggestion is that the developer can add the labels to images after the Google Cloud Vision API provide the labels, and then do the second step to use FFMPEG to convert them into video.
JiaruiJin commented 5 years ago

Thanks a lot for your advice. I actually control the number of tweets downloaded to be up to 15, so it does not matter. And I will try to learn the method to add the labels to images.