search

Joooohan / audio-recorder-streamlit

MIT License
80 stars 16 forks source link

The record button is not accessible with screen reader. #20

Closed chigkim closed 4 months ago

chigkim commented 5 months ago

Hi,

It looks like the record button is not accessible with screen readers.

The problems are:

  1. It seems clicking the svg element triggers the recording.
  2. The element has aria-hidden="true" which means telling assistive technology such as screen reader to ignore the element.
  3. The element also has focusable="false" which prevents users from focusing on the element with keyboard like tab/shift+tab and press enter/space to activate.

If I do this, it works.

  1. remove aria-hidden attribute.
  2. set focusable="true".
  3. Add role="button".
  4. Add aria-label="Record".

Could you investigate? Thanks so much!

Joooohan commented 4 months ago

Hello, I have added a proper button element which is focusable and has an aria-label. I will release it in 0.0.10.

Joooohan commented 4 months ago

I have released 0.0.10.