search

JoshCheek / miniature-octo-ironman

It's small. It had 8 legs. It sells weapons of mass comprehension to the most eager learner!
4 stars 4 forks source link

Remove js into its own file. #32

Closed AndyDangerous closed 10 years ago

AndyDangerous commented 10 years ago

The js file probably needs a better name though Closes #25

JoshCheek commented 10 years ago

Looks good, ty!

Also, I'm moving away from code review, towards just merging it into master. Code review can be good if someone isn't sure about something, but I think that every little bit helps, esp right now, and don't see value in holding up someone's work for a code review (we can always change it later). You can still ask for code review, but this doesn't need to happen before you merge it.

I updated the Readme to reflect this.

JoshCheek commented 10 years ago

Also, if you dislike the name, you can change it, or if you don't know what to change it to, you can open a new issue. Or, we can just wait and let it evolve :) No need to make decisions before there is enough context to make them well.