JoshDSommer / nativescript-ngx-slides

A NativeScript + Angular module for to add a slides component to your mobile app
Other
45 stars 34 forks source link

Webpack compatibility #27

Closed EddyVerbruggen closed 7 years ago

EddyVerbruggen commented 7 years ago

Apparently, this is required to make Webpack happy.

JoshDSommer commented 7 years ago

@EddyVerbruggen Awesome thank you!

URvesh109 commented 7 years ago

How can I use nativescript-ngx-slides with webpack

JoshDSommer commented 7 years ago

@URvesh109 here is the getting started guide for webpack and nativescript https://docs.nativescript.org/tooling/bundling-with-webpack. Or are you having issues currently. I've published this PR in the lastest update.

URvesh109 commented 7 years ago

Hello Josh,

It works as expected without webpack, but while bundling with webpack i got this error,

ERROR in Template parse errors: 'StackLayout' is not a known element:

  1. If 'StackLayout' is an Angular component, then verify that it is part of this module.
  2. To allow any element add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component. (" [ERROR ->]<StackLayout #slideLayout [class]="cssClass">

    "): ng:///home/urvesh/Miscellaneous/Nativescript/MySlides/node_modules/nativescript-ngx-slides/slides/app/slide/slide.component.ts.SlideComponent.html@1:1

JoshDSommer commented 7 years ago

@URvesh109 Thank you for the heads up, this has been fixed in the latest version(0.2.3) I simply needed to add the no_errors_schema to the ng module like the error said.

URvesh109 commented 7 years ago

Thks bro,

URvesh Ghoderao 72434043882

From: Josh Sommer Sent: 01 July 2017 05:52 To: TheOriginalJosh/nativescript-ngx-slides Cc: URvesh Ghoderao; Mention Subject: Re: [TheOriginalJosh/nativescript-ngx-slides] Webpack compatibility(#27)

@URvesh109 Thank you for the heads up, this has been fixed in the latest version(0.2.2) I simply needed to add the no_errors_schema to the ng module like the error said. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

JoshDSommer commented 7 years ago

lol two more versions since last night so we are at 0.2.4 now lol. had to fix a couple minor issues that I noticed.