search

JoshDSommer / nativescript-ngx-slides

A NativeScript + Angular module for to add a slides component to your mobile app
Other
45 stars 34 forks source link

Added 'changed' and 'finished' events #30

Closed codeback closed 7 years ago

codeback commented 7 years ago

@TheOriginalJosh I've added these two events and I tested on Android and iOS. Please can you check it?

If you have any doubts or suggestions to the PR, please ping me.

Thanks!

JoshDSommer commented 7 years ago

This is fantastic! thank you @codeback ! much appreaciated.

JoshDSommer commented 7 years ago

published in version 0.4.0 thank you @codeback!

codeback commented 7 years ago

Hi @TheOriginalJosh,

I've just tried the 0.4.0 version and it is not detecting the events. The problem is that the *.js files don't have these changes (they haven't been compiled).

Please, can you compile them and publish another release? Thank you very much.

JoshDSommer commented 7 years ago

@codeback Oh shoot, I'm sorry, I messed that up when I did the published. I just published version 0.4.1 and they will be in there now.