JoshDSommer / nativescript-ngx-slides

A NativeScript + Angular module for to add a slides component to your mobile app
Other
45 stars 34 forks source link

Added Zoom feature #37

Closed codeback closed 6 years ago

codeback commented 6 years ago

Hi @TheOriginalJosh,

I've added Zoom funcionality when you pinch in a slide. This can be useful in the use case of a carousel of images.

The feature is enabled/disabled through the SlidesComponent input 'zoomEnabled' and it works as follows:

JoshDSommer commented 6 years ago

This is really cool! thank you @codeback

codeback commented 6 years ago

Thank you @TheOriginalJosh!!

Can you update npm please?

codeback commented 6 years ago

Hey @TheOriginalJosh,

Sorry to insist. I would really appreciate if you could update the npm repository, I need it to deploy the new version of an App.

Thanks in advance!

JoshDSommer commented 6 years ago

@codeback sorry, I've had a problem with Typescript compiler when pulbishing and haven't had a chance to look at back at it.

node_modules/rxjs/Subject.d.ts(16,22): error TS2415: Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.
node_modules/tns-core-modules/ui/core/properties/properties.d.ts(48,14): error TS2559: Type 'Property<T, U>' has no properties in common with type 'TypedPropertyDescriptor<U>'.
node_modules/tns-core-modules/ui/core/properties/properties.d.ts(59,14): error TS2559: Type 'CoercibleProperty<T, U>' has no properties in common with type 'TypedPropertyDescriptor<U>'.
codeback commented 6 years ago

Hi @TheOriginalJosh,

If I run 'npm run prepublish', it compiles ok. What version of typescript are you using?

$ tsc -v
Version 2.3.4
JoshDSommer commented 6 years ago

Hmm. I'm using 2.5.3 I downgraded to 2.3.4 and was able to publish. I published this as version 0.4.4 with a beta tag. Thanks again @codeback