search

JoshDSommer / nativescript-ngx-slides

A NativeScript + Angular module for to add a slides component to your mobile app
Other
45 stars 34 forks source link

Angular 4 support ? #45

Closed RoyiNamir closed 6 years ago

RoyiNamir commented 6 years ago

image

JoshDSommer commented 6 years ago

Angular 4 is supported. from your screenshot, it appears the dependencies are not installed correctly.

RoyiNamir commented 6 years ago

@TheOriginalJosh I didnpm install. What else should I do ?

JoshDSommer commented 6 years ago

You should run the setup script. that should install the dependencies necessary to develop the plugin.

RoyiNamir commented 6 years ago

@TheOriginalJosh I've already run it as you can see in the image...

image

JoshDSommer commented 6 years ago

That appears to have failed then, you can always go into the projects directories an manually install as well

RoyiNamir commented 6 years ago

@TheOriginalJosh I did it , but guess what is found under the dempo package.json :

https://github.com/TheOriginalJosh/nativescript-ngx-slides/blob/master/demo/package.json#L25

Still not working and I don't think that this path should be there. too bad that's how it is. (I've changed the path to my path - still no success) :

image

In short . can you please fix this plugin so it will work for the community ? - Thanks in advance ! :-)

JoshDSommer commented 6 years ago

The current plugin state is functional. The file path that's left over from my local dev environment. however, when running the demo script it should update that with the correct file path for the local install. you may want to try a different version of NPM? What are you trying to do exactly?

RoyiNamir commented 6 years ago

Im trying to see it in my android app. In mobile. Im not new to ns It's just doesnt work

JoshDSommer commented 6 years ago

You can try going into the slides directory, running npm install in there and then run tns run android that should work fine for you to see the development environment. Alternatively, you could try creating a new project doing and adding it from npm, then in there.

I'm closing this issues for now. But in the future please include a more descriptive issue of what you've done and your development environment. Just a screen shot isn't helpful.

FranciZ commented 6 years ago

@TheOriginalJosh It did compile and install going to slides and running npm i && tns run android but there's an issue I guess with the new version of tns or something. What I get is the below screenshot. I've tried implementing the thing into my project but it's doing the same thing. Just overlaying slides one over the other with no sliding working and no error to debug.

My tns cli version is 3.4.0. tns-android is 3.0.0

Any suggestions? Thanks!

screenshot_20171227-105856