search

JoshDSommer / nativescript-ngx-slides

A NativeScript + Angular module for to add a slides component to your mobile app
Other
45 stars 34 forks source link

Nativescript 4 compatibility #59

Closed darxmac closed 6 years ago

darxmac commented 6 years ago

Looks like the package.json in dist includes "tns-core-modules": "~3.4.0" and that gives the following error after upgrading the project to 4.0.0:

2018-04-14 15:24:21.559711+0200 xxx[45216:352271] JavaScript error:
2018-04-14 15:24:21.559913+0200 xxx[45216:352271] file:///app/tns_modules/nativescript-ngx-slides/node_modules/tns-core-modules/application/application.js:242:75: JS ERROR Error: A Frame must be used to navigate to a Page.

file:///app/tns_modules/nativescript-ngx-slides/node_modules/tns-core-modules/application/application.js:242:75: JS ERROR Error: A Frame must be used to navigate to a Page.

Removing the dependencies makes the project build and run again

trunkovich commented 6 years ago

@TheOriginalJosh we need your help here.

trunkovich commented 6 years ago

@darxmac did you find a workaround to run it with tns-core-modules v4?

otnielgomez commented 6 years ago

+1

JoshDSommer commented 6 years ago

Hi everyone, sorry for the delay here, I'm looking into this currently, I think it may be best to move the project over to something like NG-packagr to resolve this problem. i've looked into this a little but I havne't had a lot of free time to really sit down and work on this

Ross-Jo commented 6 years ago

+1

anuragd7 commented 6 years ago

+1

JoshDSommer commented 6 years ago

First off I'm really sorry for the long delay. but I've published a new version of slides (1.0.6+) that is built with ng-packagr that should fix this problem. If you could take a moment to let me know if it works for you or not I would appreciate it.

Closing this for the time being but feel free to re-open it if need be.