search

Joshua-Ashton / d9vk

A Direct3D9 to Vulkan layer using the DXVK backend. [Upstreamed to DXVK]
https://github.com/doitsujin/dxvk
zlib License
833 stars 42 forks source link

Senran Kagura Shinovi Versus: Letterboxed Fullscreen #460

Closed ryester19 closed 4 years ago

ryester19 commented 4 years ago

Software information

Senran Kagura Shinovi Versus Arch Linux

System information

Apitrace file(s)

https://mega.nz/#!qpxy1IYa!GXJJI5t8-5IApIsjJ6pQRTH0837GyZNpqohykTgdLX4

Log files

steam-411830.log

There appears to be a letterbox effect going on with the game, despite the monitor being 1080p 16:9, and the game resolution set correctly

D9VK Screenshot_20191124_232341

WineD3D Screenshot_20191124_232738

K0bin commented 4 years ago

Probably related to #337

Joshua-Ashton commented 4 years ago

Can't repro on the trace, could you provide a trace made with d9vk?

Joshua-Ashton commented 4 years ago

So I've tested this with the actual game, and the same behaviour is present when using native d3d9.

ryester19 commented 4 years ago

So I've tested this with the actual game, and the same behaviour is present when using native d3d9.

So that means this is a mesa issue?

Joshua-Ashton commented 4 years ago

No, I mean it happens in Windows d3d9 too for me... (I have the game)

I'm using a 4K monitor, and disabling certain modes caused it to pick the right ones. I think this might be a game bug.

Can possibly work around it though.

Joshua-Ashton commented 4 years ago

Yeah this is technically a game bug, when 64:27 modes are exposed, it craps out.

ryester19 commented 4 years ago

No, I mean it happens in Windows d3d9 too for me... (I have the game)

I'm using a 4K monitor, and disabling certain modes caused it to pick the right ones. I think this might be a game bug.

Can possibly work around it though.

Strange. Guess I never thought about it being a game issue because the last time I played on Windows was with a 16:10 monitor, and top-bottom letterboxing is just a part of life when playing console ports made for 16:9 TVs. Sounds like Wine must have patched in a workaround at some point

Do you still want a d9vk trace at this point?

Joshua-Ashton commented 4 years ago

I dont need a d9vk trace anymore its fine

Joshua-Ashton commented 4 years ago

Can you try with this build to see if it fixes it?

d3d9.zip

ryester19 commented 4 years ago

Can you try with this build to see if it fixes it?

d3d9.zip

I will let you know this evening 👍

Joshua-Ashton commented 4 years ago

Feel free to re-open if it persists...

ryester19 commented 4 years ago

Can you try with this build to see if it fixes it?

d3d9.zip

Just gave it a try. I didn't see any changes.

I'm assuming the instructions for installing this test DLL are the exact same as setting up for a trace?

Joshua-Ashton commented 4 years ago

Well yeah, I also pushed the changes to latest, which fix the issue for me.

Joshua-Ashton commented 4 years ago

If that doesn't work then please trace...

ryester19 commented 4 years ago

okay got a new d9vk trace for you

https://mega.nz/#!f1BwzKwQ!u4i03_PvNln-zNSnDus2U0hKRugUpEZkqAIQplx3DAU

Joshua-Ashton commented 4 years ago

I didn't mean to re-close this sorry, re-base doing rebase things

Joshua-Ashton commented 4 years ago

Can you try with 4caa51ff3cf0ac2da64c7d69855346b8031630d1

ryester19 commented 4 years ago

Looks like you got it. Thanks for the fix!

Screenshot_20191127_185233