search

JujaLabs / itevents

Resource to subscribe on it events
Apache License 2.0
7 stars 5 forks source link

Refactor exception handling #168

Open alex-anakin opened 8 years ago

alex-anakin commented 8 years ago

Begin is in class MailBuilderUtil in BuildXmlFromUserOtp(User user, OneTimePassword oneTimePassword) method. Exception 'java.io.IOException' is never thrown in the method.

Then move by methods usages chain. Whenever you see throws Exception it need to refactor code. Exception is too broad, masking specific exceptions.

IgorMaksymov commented 8 years ago

@AndriyBaibak time spent: 3h

IgorMaksymov commented 8 years ago

@romach @vaa25 @alex-anakin also i removed antipatterns that discribed here https://community.oracle.com/docs/DOC-983543

IgorMaksymov commented 8 years ago

@AndriyBaibak time spent: 1h