JuliaAlgebra / MultivariatePolynomials.jl

Multivariate polynomials interface
https://juliaalgebra.github.io/MultivariatePolynomials.jl/stable/
Other
135 stars 27 forks source link

CompatHelper: bump compat for MutableArithmetics to 1, (keep existing compat) #193

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the MutableArithmetics package from 0.3 to 0.3, 1. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

schillic commented 2 years ago

Do you mind merging this PR? It is blocking package updates elsewhere.

I tested it locally and it works. But there is something to note: Since MP depends on TypedPolynomials and that package depends on MP again, the new version MutableArithmetics v1 would not be used in CI. One needs to update both packages simultaneously to see the effect. This is what I did on my end: I created a new environment with just these packages, added MutableArithmetics v1 to the Project.toml files, ran Pkg.resolve and installed MutableArithmetics v1, and finally ran the tests (where I checked that MutableArithmetics v1 was used). The tests passed for both packages.

(By the way, TypedPolynomials still uses a previous version of MP and hence the new version is actually never used at the moment. That should probably also be fixed.)

As a side note, you can set up CompatHelper to run the CI script by adding the following line here (as it is done here):

COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }}
blegat commented 2 years ago

Thanks for checking. MA does not have anything breaking so it should work indeed

schillic commented 2 years ago

Thanks! I will send PRs to TypedPolynomials and then to DynamicPolynomials.

(By the way, TypedPolynomials still uses a previous version of MP and hence the new version is actually never used at the moment. That should probably also be fixed.)

That was wrong, sorry. It does consider patch updates.