JuliaAlgebra / MultivariatePolynomials.jl

Multivariate polynomials interface
https://juliaalgebra.github.io/MultivariatePolynomials.jl/stable/
Other
135 stars 27 forks source link

Fix rrule for * and add support for constant operations #211

Open blegat opened 2 years ago

blegat commented 2 years ago

I am a bit unsure what to do here. I think we should define rrule based on LinearAlgebra.dot so we should remove the definition of the rule for differentiate and keep the old one for *.

@harris-mit I would expect that the current rule for differentitation gives incorrect result when you use it with AD since it assumes a scalar product that is not what is used, does it work for you ?

blegat commented 1 year ago

@oxinabox this is the issue I mentioned to you at JuliaCon

oxinabox commented 1 year ago

@Sethaxen might have thoughts here