JuliaAlgebra / MultivariatePolynomials.jl

Multivariate polynomials interface
https://juliaalgebra.github.io/MultivariatePolynomials.jl/stable/
Other
134 stars 27 forks source link

add type asserts for `MA.operate!` return values #286

Open nsajko opened 8 months ago

nsajko commented 8 months ago

This helps ensure the MutableArithmetics contract is respected. Specifically, MA.operate! should always return its first argument.

Why this instead of performing a stronger check with ===? Because:

blegat commented 7 months ago

Is this improving any benchmark or just some double checks ? In any case, please fix the format error and then it should bz good