JuliaCloud / JuliaBox

Juliabox continues to run, but this codebase is no longer current.
http://www.juliabox.org/
Other
185 stars 50 forks source link

Juliabox url when not logged in #328

Open mturok opened 8 years ago

mturok commented 8 years ago

Hi,

I was wondering if it were possible to have a juliabox url take me to the authentication page if I'm not currently logged in.

For example, if I haven't logged into juliabox yet, and I try to navigate to a notebook at a url like: https://juliabox.org/notebooks/MIC.ipynb, I get an error message that says "Signature mismatch". However, if I'm already logged in, I see a jupyter notebook.

I'm thinking that what would be nice is to first be taken to the authentication page, and then if I log in successfully, to navigate to the url.

Happy to make the changes....any pointers appreciated.

Michael

tanmaykm commented 8 years ago

Hi Michael,

router.lua currently checks for valid sessions before letting URLs through. See https://github.com/JuliaLang/JuliaBox/blob/58e9cd90c9fef4a2cb4dcc3d34cbca64642cbe35/webserver/scripts/router.lua#L262

Invalid sessions result in error (forbid_invalid_session method: https://github.com/JuliaLang/JuliaBox/blob/58e9cd90c9fef4a2cb4dcc3d34cbca64642cbe35/webserver/scripts/router.lua#L232). It can redirect to the authentication page instead.

The initial URL can be saved in a cookie, and acted upon after authentication.

xiuliren commented 6 years ago

BTW, juliabox.org do not work now, the link should be juliabox.com