search

JuliaIO / Parquet.jl

Julia implementation of Parquet columnar file format reader
Other
119 stars 32 forks source link

Add bounds in REQUIRE file #14

Closed davidanthoff closed 6 years ago

davidanthoff commented 6 years ago

I assume these are needed for METADATA registration.

tanmaykm commented 6 years ago

I don't think we need to specify lower bounds unless we rely on a specific behavior of the package not available before that...

Is there such a need here?

davidanthoff commented 6 years ago

I believe the current METADATA policy is that everything needs an explicit lower bound, even if it is 0.0.1. I certainly got PRs on METADATA rejected in the past because I missed those. @aviks is that correct?

I slightly changed the bounds now: for packages where I don't know what the min version is that is compatible I just put in the lowest version number. For other packages (like Snappy.jl), I've left the bounds in that we need.

I think it should be safe to merge this: when in doubt it will increase the likelihood that the package can be registered in METADATA.jl in one go without rounds of change-requests, and these super low bounds certainly can't do any harm.