search

JulianKemmerer / PipelineC

A C-like hardware description language (HDL) adding high level synthesis(HLS)-like automatic pipelining as a language construct/compiler feature.
https://github.com/JulianKemmerer/PipelineC/wiki
GNU General Public License v3.0
606 stars 50 forks source link

Examples missing `#pragma main` #124

Closed rachitnigam closed 2 years ago

rachitnigam commented 2 years ago

The matrix_mult_ examples are missing #pragma MAIN main from the C files which causes the tool to immediately error out. Should those exist there by default?

JulianKemmerer commented 2 years ago

Oh gosh ew - those are some old examples and may have rotted away a little

Thanks for bringing to attention! Will be taking a look...

rachitnigam commented 2 years ago

Maybe it would be useful to have some continuous testing to keep the examples up to date! For example, we use runt to do this very lightweight but useful form of expectation testing. Maybe sometime like that would be useful? Happy to help figure out how to set it up if that'll be useful!

JulianKemmerer commented 2 years ago

@rachitnigam some sort of CI does sound like a good idea - sadly it hasn't been prioritized as of yet

I highly encourage you to continue any discussion on this general issue over here https://github.com/JulianKemmerer/PipelineC/issues/104

JulianKemmerer commented 2 years ago

Fixed missing MAIN pragmas in recent commit :+1: