Network: Timeout disconnecting from listening connections

JurgenR / aioslsk

SoulSeek client library using Python asyncio

GNU General Public License v3.0

17 stars 0 forks source link

Network: Timeout disconnecting from listening connections #273

Closed JurgenR closed 2 months ago

JurgenR commented 2 months ago

This was supposed to already be handled in #184 but I accidentally put the timeout on the DataConnection instead of the ListeningConnection. Set this straight and do an investigation if there isn't a more elegant solution.

JurgenR commented 2 months ago

This might be Python 3.12 specific. There is some discussion going on here: https://github.com/python/cpython/issues/104344 where is seems it has been changed already twice in the supported versions by the library. I currently just added the timeout and lowered it to 5 seconds.