KED-2020 / api-mind-map

1 stars 1 forks source link

Feat subscription and favorites #11

Closed derrxb closed 3 years ago

derrxb commented 3 years ago

This PR should be reviewed after https://github.com/KED-2020/api-mind-map/pull/10 since it builds from where I left off there. This PR does two main things:

The main idea of this PR is the setup both the favourites and the subscriptions table. While working on it, I changed a few things though since it made the work easier.

derrxb commented 3 years ago

Oops, specs blew up. I will fix this asap.

Kyeg commented 3 years ago

This is my testing, there is one Failure, is it normal or I should do some configuration before testing?

$ rake spec:all

Run options: --seed 31194

# Running:

...........SS..........F........

Finished in 1.311295s, 24.4034 runs/s, 86.1744 assertions/s.

  1) Failure:
Test API routes::Get inbox documents route#test_0002_should return an documents lists when they exists for an inbox [/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/spec/tests_acceptance/api_spec.rb:202]:
Expected: 1
  Actual: 0

32 runs, 113 assertions, 1 failures, 0 errors, 2 skips

You have skipped tests. Run with --verbose for details.
Coverage report generated for RSpec to /Users/kyeg_logos_mac/GitHub_Box/api-mind-map/coverage. 985 / 1051 LOC (93.72%) covered.
rake aborted!
Command failed with status (1)

Tasks: TOP => spec:all
(See full trace by running task with --trace)
derrxb commented 3 years ago

This branch is outdated. You should run the master as it has the latest updates

Kyeg commented 3 years ago

So in the #12, every test on the api will be passed?

Kyeg commented 3 years ago

Oh, I saw it: https://github.com/KED-2020/api-mind-map/pull/12 It seems checked by GitHub Action. Ok, then I have no problem.