search

KED-2020 / api-mind-map

1 stars 1 forks source link

Save discard suggestion #12

Closed derrxb closed 3 years ago

derrxb commented 3 years ago

This adds the save discard feature to the API. I think I will add the front-end functionality after this. I think there might still need to be some more changes + tests later on. But I will try to add that early tomorrow or after I get done with the feature.

derrxb commented 3 years ago

I'd like to highlight this commit: https://github.com/KED-2020/api-mind-map/pull/12/commits/dfb0aa44b83e615a0140d12235a95b466d717332

In the API we used to refer to inbox_url as inbox_id. This caused a bunch of confusion since we would need to be aware of this fact. So I just all references to inbox_id => inbox_url.

Kyeg commented 3 years ago

Ok, I have reviewed it, all api test in the api server look great! Thanks!

For the app server: image The Find Inbox button in app test looks fine. But the Create New Inbox button in app test seems broken. If we click the button, the error message in the app server is: NameError: uninitialized constant MindMap::Service::GetNewInboxId.

I guess this will be fixed in the following branch.