search

KED-2020 / api-mind-map

1 stars 1 forks source link

Should we move our version to 2.7.2, or just neglect the warning? #4

Closed Kyeg closed 3 years ago

Kyeg commented 3 years ago

A suggestion is about changing the ruby version.
Current version is Ruby 2.7.1. Although the tests can be passed, there are some warning (maybe because we have used DRY-TRANSACTION gem, I guess).

I re-test our app in Ruby 2.7.2. All above warnings can be removed, and all the tests can still be passed. So do you consider to move our app from Ruby 2.7.1 to Ruby 2.7.2?

Run in Ruby 2.7.1:

> rake spec:all

Run options: --seed 29510

# Running:

/Users/kyeg_logos_mac/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/dry-transaction-0.13.0/lib/dry/transaction/instance_methods.rb:17: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/dry-transaction-0.13.0/lib/dry/transaction/instance_methods.rb:84: warning: The called method `resolve_operation' is defined here
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/get_inbox.rb:53: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
./Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/get_inbox.rb:34: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
./Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/add_document.rb:60: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
./Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/add_document.rb:50: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
../Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/requests/add_document.rb:29: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
............/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/controllers/app.rb:24: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
.../Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/get_document.rb:16: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
../Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/application/services/get_document.rb:18: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/kyeg_logos_mac/GitHub_Box/api-mind-map/app/presentation/responses/api_result.rb:17: warning: The called method `initialize' is defined here
...

Finished in 1.785830s, 13.9991 runs/s, 52.0766 assertions/s.

25 runs, 93 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for RSpec to /Users/kyeg_logos_mac/GitHub_Box/api-mind-map/coverage. 870 / 904 LOC (96.24%) covered.

Run in Ruby 2.7.2:

> rake spec:all

Run options: --seed 15397

# Running:

.........................

Finished in 1.216331s, 20.5536 runs/s, 76.4595 assertions/s.

25 runs, 93 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for RSpec to /Users/kyeg_logos_mac/GitHub_Box/api-mind-map/coverage. 870 / 904 LOC (96.24%) covered.
derrxb commented 3 years ago

I think we should upgrade. This is super annoying haha especially when our tests fail it makes it hard to read the error messages