KSP-RO / ROEngines

Engine models and part configs to replace the generic Squad engines for Realism Overhaul
Other
22 stars 43 forks source link

V-2 Derivatives don't have the proper diameter #210

Open Darkfalcon1 opened 1 year ago

Darkfalcon1 commented 1 year ago

V-2 style engines appear to be 1.3m in diameter, however, the VAB detects them to be 2.2m in diameter.

Capkirk123 commented 1 year ago

Which engine, from which mod? RP-1 is not responsible for the scaling of parts.

arrowmaster commented 1 year ago

@Capkirk123 I believe I saw a comment about this on discord and that its the engineer report saying the diameter is 2.2m with only an A-4 or RD-100 engine as the only part. I have not tested this.

Capkirk123 commented 1 year ago

Moved to ROEngines since it's probably the relevant mod

NathanKell commented 1 year ago

IIRC it's a bounds problem that @AlphaMensae mentioned on stream that afflicts some other parts, wherein KSP does bounds calcs based off some invisible transforms. The visual engine is sized correctly but there's some invisible transforms that bulk it out. This isn't noticeable in practice (usually) because of fins.

Capkirk123 commented 1 year ago

This appears to be another occurrence of the issue here

Capkirk123 commented 1 month ago

Partially resolved by https://github.com/KSP-RO/ROEngines/pull/246 giving vero a dedicated model