search

KSP-RO / ROEngines

Engine models and part configs to replace the generic Squad engines for Realism Overhaul
Other
21 stars 42 forks source link

LR-87 Diameter of 3m instead of 1.53 / 1.14m #219

Open westlakem opened 1 year ago

westlakem commented 1 year ago

The LR87 had a diameter of 1.53m and 1.14m (depending on the variant) but the VAB shows them all as 3m. image

Aerobee on a 1m diameter probe core image LR87 on a 1m diameter probe core image

Vessel with 1.7m diameter boosters (6.5m total length) image Vessel with 1.7m diameter boosters + LR87 engines (7.8m total length) image

Capkirk123 commented 12 months ago

This appears to be because the Engineer's Report can still see parts of a model hidden by B9PS. The BDB LR87 model has a 3-meter mount which is hidden by ROEngines and B9PS, but still causes the Engineer's Report to report it as 3 meters wide.

The issue should probably be resolved by getting B9PS to hide the bounds of disabled models better.

al2me6 commented 12 months ago

The fundamental issue is that KSP doesn't care about whether a transform is enabled or not when calculating bounds, so there's not much else B9PS can do. We'll have to clobber the computation in KSPCF.

On Oct 15 2023, at 8:28 pm, Capkirk123 @.***> wrote:

This appears to be because the Engineer's Report can still see parts of a model hidden by B9PS. The BDB LR87 model has a 3-meter mount which is hidden by ROEngines and B9PS, but still causes the Engineer's Report to report it as 3 meters wide. The issue should probably be resolved by getting B9PS to hide the bounds of disabled models better. — Reply to this email directly, view it on GitHub (https://github.com/KSP-RO/ROEngines/issues/219#issuecomment-1763555763), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AINB675SQWDBLLECGREIT33X7R5TVAVCNFSM6AAAAAA4SO5UMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGU2TKNZWGM). You are receiving this because you are subscribed to this thread.

NathanKell commented 12 months ago

I mean... https://github.com/KSP-RO/RP-1/blob/af00ea7e4b2e92b38094a4574ebf5e6083d79ec1/Source/RP0/Utilities/KCTUtilities.cs#L278