search

KSP-RO / ROEngines

Engine models and part configs to replace the generic Squad engines for Realism Overhaul
Other
21 stars 42 forks source link

Fix Modular RCS Restock models scale #236

Open ezsnackeur opened 2 months ago

ezsnackeur commented 2 months ago

Changes the scale on the Restock models to be in line with all the other models. Mini ones are still a little bit smaller at 2/3 the nozzle diameter compared to the rest.

siimav commented 2 months ago

The regular-type Restock variants look all good. 1- and 5-way Restock mini looks good; 2-, 3- and 4-way mini models are still a bit too small IMO.

ezsnackeur commented 2 months ago

All the mini variants share the same nozzle diameter as they did before. i dont know what you are referring to :< image

siimav commented 2 months ago

Ugh, the Restock mini parts are weird in that they're the same height as regular ones but nozzle diameter and the rest of the dimensions are way smaller. image

ezsnackeur commented 2 months ago

i think the base of the mini ones is just supposed to be offset into the tank its placed on tbf. image like this for reference.

they would look very weird if 1 axis is scaled differently to the others. maybe i should make the mini ones 1/2 scale instead of 2/3? they would still be bigger than what they were originally

Capkirk123 commented 2 months ago

I don't think that's what's being suggested.

Just scale based on the nozzle (it's more realistic, and it'll make the engine plume fit more consistently). It's fine if one part ends up a little bulkier than another in the end.

ezsnackeur commented 2 months ago

Thats exactly what i did. all the restock models match all the other models nozzle diameter while mini ones are 2/3 nozzle diameter.

ezsnackeur commented 1 month ago

So should i change anything or? In my opinion this is fine as is

siimav commented 1 month ago

I'm personally not happy with the fact that the mini variant produces the same thrust at significantly smaller throat and nozzle sizes. I guess it's still an improvement over the previous state though.

ezsnackeur commented 1 month ago

If you make them same nozzle diameter the mini ones come out as a bigger model overall (as you pointed out the model is already very tall) that wouldn't make sense imo.