search

Kalanyr / gogrepoc

Python-based tool for downloading all your GOG.com game and bonus collections to your local computer for full offline enjoyment.
262 stars 36 forks source link

gogrepoc failing to pull .exe files #114

Open drijen opened 2 months ago

drijen commented 2 months ago

OS: Ubuntu 24.04.1 LTS Python 3.12.3-0ubuntu2

Running gogrepoc will result in a manifest that includes all files except the actual game .exe or any other non linux executable. Shell scripts for linux compatible games will be downloaded, but not their windows counterparts.

Example game: blake_stone_aliens_of_gold, linux and windows compatible; gogrepoc pulls .sh, but not .exe. Example game 2: baldurs_gate_iii, windows only; no files downloaded aside from "extras".

Have attached manifest and log, please let me know what else I can do to assist.

Kalanyr commented 2 months ago

What commands are you using ? The default behaviour on Linux is to update/download only Linux files + Extras unless something else is specificed with -os.

On Fri, 27 Sept 2024, 06:38 drijen, @.***> wrote:

OS: Ubuntu 24.04.1 LTS Python 3.12.3-0ubuntu2

Running gogrepoc will result in a manifest that includes all files except the actual game .exe or any other non linux executable. Shell scripts for linux compatible games will be downloaded, but not their windows counterparts.

Example game: blake_stone_aliens_of_gold, linux and windows compatible; gogrepoc pulls .sh, but not .exe. Example game 2: baldurs_gate_iii, windows only; no files downloaded aside from "extras".

Have attached manifest and log, please let me know what else I can do to assist.

gogrepo.log https://github.com/user-attachments/files/17155738/gogrepo.log gog-manifest (Copy).txt https://github.com/user-attachments/files/17155761/gog-manifest.Copy.txt

— Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/114, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ335WWTDTBUXGIQ5PSJLZYRWFNAVCNFSM6AAAAABO5ZYC2CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TCNBZGIZDMNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

drijen commented 2 months ago

Ah, I see my error now.

Before, I took the default os selection behavior to be "all". Executing 'python3 gogrepoc.py update -os windows -os linux' resolved my issue.

I apologize, and also - thanks for maintaining this tool; really appreciate it.

danielaixer commented 1 month ago

@drijen I think you may want to remove your email from the log file, for privacy reasons...

danielaixer commented 1 month ago

Also, related to the issue's theme:

DO NOT forget to also specify -lang as well as -os. I've been debugging the script for over an hour because I wasn't able to pull the installers, even after specifying the OSes: python gogrepoc.py update -os windows linux -full This was giving me only the extras...

After investigating how the filter_downloads function works and checking which lang_list it was working with, if found out that this was the required command: python gogrepoc.py update -os windows linux -lang en es -full

I'm using the -full parameter just in case.

@Kalanyr I would strongly recommend updating the "Quick Start -- Typical Use Case" readme section, by including there the -os or -lang parameters (not only under "Advanced Usage -- Common Tasks") or by adding a clear disclaimer indicating that gogrepoc.py update,etc. filter by the current OS and OS' language.

Kalanyr commented 1 month ago

Yes, I'll make a note to add that the default behaviour is to download only the current OS and current system language ( this seems to be the behaviour that's generally expected but it does get weird if you're running the script on a *nix NAS and are generally a Windows users or if you own games not in your System language ( which is probably way more common for languages other than English ) .