Kalanyr / gogrepoc

Python-based tool for downloading all your GOG.com game and bonus collections to your local computer for full offline enjoyment.
256 stars 36 forks source link

Linux installers not found? #28

Open gatl opened 4 years ago

gatl commented 4 years ago

The game Master of Orion 2 has an installer for Linux (since the end of 2015, according to the GOG changelog). However, gogrepoc does not see it? Is this an issue on my side only? This is what I tried:

python gogrepo.py update -ids 1207661633 -installers standalone 
python gogrepo.py download -ids 1207661633 -os linux -skipextras -- gog

I found no mention of a Linux installer on the manifest file and found no Linux installer found on the game directory. Am I doing something wrong?

Kalanyr commented 4 years ago

It's in my manifest

            {'desc': 'Master of Orion 2',
             'href': 'https://www.gog.com/downloads/master_of_orion_2/en3installer1',
             'lang': 'English',
             'md5': '51529fd6734bc12f1ac36fea5fc547f8',
             'name': 'gog_master_of_orion_2_2.0.0.6.sh',
             'old_name': None,
             'os_type': 'linux',
             'prev_verified': True,
             'size': 187179637,
             'version': '1.40b23 (gog-6)'}],

And I have it downloaded.

I think your problem is you didn't include the os argument in the update command, it defaults to the platform you're running it on rather than all of them.

gatl commented 4 years ago

Well, I only have Linux, so it may have been something else. I removed the manifest file and I can find the relevant file there. I can't reproduce this problem now, but I'll try to do a more thorough investigation of the issue if I came across it. I'm glad it was not something I broke by accident. :-)

Oh, well, feel free to close this issue. I'm sorry to have bothered you.

Kalanyr commented 4 years ago

It's possible that automatic OS detection is broken under some circumstances.

Just to verify it's safe to close: a clean manifest currently finds the Linux installer for MoO2 ?

On Sat, 1 Feb 2020, 8:23 pm gatl, notifications@github.com wrote:

Well, I only have Linux, so it may have been something else. I removed the manifest file and I can find the relevant file there. I can't reproduce this problem now, but I'll try to do a more thorough investigation of the issue if I came across it. I'm glad it was not something I broke by accident. :-)

Oh, well, feel free to close this issue. I'm sorry to have bothered you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/28?email_source=notifications&email_token=ABKZ33YKLWERBGJS5RFJIIDRAVESFA5CNFSM4KMJVFM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQZRYA#issuecomment-581015776, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ333OIMHELHWP2ZMOAXTRAVESFANCNFSM4KMJVFMQ .

gatl commented 4 years ago

I looked into it and indeed it is as you suspected: if I do not specify I want to include Linux the program considers just the Windows installer.