search

KallDrexx / rust-media-libs

Rust based libraries for misc media functionality
Apache License 2.0
229 stars 58 forks source link

Make rml_rtmp::handshake::HandshakeError public #1

Closed njoyce closed 6 years ago

njoyce commented 6 years ago

Hi!

First, thanks for a great library - really enjoying working with it so far. I am fairly new to Rust and am currently building an rtmp server with tokio (using the mio example as a base).

Currently HandshakeError is only publicly availble through rml_rtmp::handshake::errors but is privately imported in rml_rtmp::handshake.

When working on the handshake phase of the connection, I imported all the components I required via rml_rtmp::handshake::{HandshakeResult, Handshake, PeerType}, but had to have a separate import to get access to the HandshakeError.

I suggest for simplicity publicly exposing HandshakeError through rml_rtmp::handshake.

KallDrexx commented 6 years ago

Good catch, it should definitely be in importable via rml_rtmp::handshake::HandshakeError;! I can fix this later today :)

Don't hesitate to point out any oddities that come from implementing it with Tokio. I wanted to do a Tokio implementation but didn't want the overhead of learning Rust + RTMP + tokio all at the same time :)

KallDrexx commented 6 years ago

Fixed in f3dd5181bf26e75ac82dead07d4acf1e318d7c33 (upped version number since it can cause compilation errors on existing code)