search

KallDrexx / rust-media-libs

Rust based libraries for misc media functionality
Apache License 2.0
229 stars 58 forks source link

Are videocodecid and audiocodecid wrong type of onMetaData? #30

Closed simon-fu closed 2 years ago

simon-fu commented 2 years ago

videocodecid and audiocodecid are number type but processed as string.

KallDrexx commented 2 years ago

You look to be correct. I am not sure why I encoded it as a string, I guess I could not find definitive information at the time that it would always be a numeric value, but a guide on Adobe's site seems to confirm it .

simon-fu commented 2 years ago

I'm glad that you confirm it and looking forward to next commit.

KallDrexx commented 2 years ago

Yeah sorry, Ive been a bit busy lately. I'll try to get a fix checked in and new release cut within the next week

KallDrexx commented 2 years ago

Just pushed up 0.7.0 with the change for this. Thanks for noticing!