search

KallDrexx / rust-media-libs

Rust based libraries for misc media functionality
Apache License 2.0
229 stars 58 forks source link

Server tests cleanup #33

Closed rawler closed 1 year ago

rawler commented 1 year ago

Minor reduction of boilerplate an repeated blocks in sessions/server/tests.rs

rawler commented 1 year ago

As a thank you for the speedy review and acceptance of last PR, here is a small cleanup-PR to the tests.

It's trying to make the test-suite a bit shorter and easier to read by eliminating some repeated code-blocks throughout all the tests.

I guess it's always a personal preference between explicit vs. terse, so absolutely no problem if you prefer the code the way it was.

KallDrexx commented 1 year ago

Definitely love this, thanks! I've come to the conclusion in my newer code bases and do something similar to condense code setup. This was still early on in my rust endeavors, and thus it looks like it does :).

rawler commented 1 year ago

and thus it looks like it does

Absolutely no judgement passed. Your code has been very useful to us, so I'm just happy to back-contribute when I can :)