KallDrexx / rust-media-libs

Rust based libraries for misc media functionality
Apache License 2.0
229 stars 58 forks source link

ServerSessionEvent::ReleaseStreamRequested is never constructed #38

Open sfackler opened 1 year ago

sfackler commented 1 year ago

It looks like this event isn't currently generated by the ServerSession though it is defined.

KallDrexx commented 1 year ago

Hrm woops. I wonder if most RTMP clients I dealt with always disconnected on a stop and never encountered one that does a release stream while maintaining its connection.

sfackler commented 1 year ago

There doesn't seem to be super clear documentation about it anywhere, but from some googling, it seems like the command allows one client to kick another off of a stream so it can take over. Not sure when/why you'd want to do that...

KallDrexx commented 1 year ago

It's been a while, but I think the last time I wiresharked some clients they all did releaseStream() before they disconnected. So I think it was fairly standard to send the command, but since we need to (logically) release the stream when a disconnect occurred it seemed a bit pointless.

I think the use case of one client kicking another off is when the RTMP client was used way back in the flash days as a holistic API into a media server. These days you'd almost always back off the media server with a stand alone API that can perform a lot of these actions for it (especially since you'd usually want media server that can do more than just RTMP).

I never even found a RTMP client that even managed multiple streams at one time. Everything in the last decade is 1 connection for each publish or playback.

ROBERT-MCDOWELL commented 1 year ago

@KallDrexx I have an adobe media server on my server so I can give you access if you wish. as a flash client I used to code a web app that can manage multiple connections (8 max) and multiple streaming (publish and play) 16 max for all connections so if there are 8 connections there will be 2 streams each.

KallDrexx commented 1 year ago

@ROBERT-MCDOWELL Thanks for the offer. Unfortunately, with two kids now my free time is limited, so I haven't been doing much with RTMP in general lately. So I probably don't need it unless someone reports a bug with a workflow that needs it

ROBERT-MCDOWELL commented 1 year ago

@KallDrexx understandable....