search

KaotoIO / kaoto

Next version of the UI of the Kaoto project
Apache License 2.0
22 stars 22 forks source link

Preview pull requests #1014

Open lordrip opened 3 months ago

lordrip commented 3 months ago

Please describe the feature that you want to propose

As a way to improve the PR's review process, it would be beneficial to have them deployed in a special URL, that lives as long as the PR is open.

To top it off, it would even better to have this URL automatically written in the PR once is available.

lordrip commented 3 months ago

AtlasMap used Netlify for previewing purposes.

lhein commented 2 weeks ago

@igarashitm Do you know how to achieve that? Would be great if you could take this one.

igarashitm commented 1 week ago

What's found so far

Netlify

It only offers Java8 at build time while we need Java21

Vercel

It's possible to install java21 with dnf. With the free plan, only an individual account can access vercel configuration page. Not just an email address, but it needs a phone number to receive a one time pass. In order to enable team management functionality, it needs a paid account (pro). OSS project sponsorship is on hold - https://vercel.com/guides/can-vercel-sponsor-my-open-source-project

deploy-pr-preview GitHub Action

It allows deploying/updating/deleting temporary preview to the GitHub pages subdirectory for each PRs. Currently it doesn't support PRs from forked repo. It's planned to support in v2. However, the action author doesn't recommend deploying preview with the PR from forked repo due to security concern. It is suggested to use 3rd party hosting service instead.

igarashitm commented 1 week ago

I was looking at the last option, manually upload/delete PR preview to the GitHub pages subdir, but turns out upload-pages-artifact action requires the page artifact to be a single tar ball, i.e. it doesn't allow uploading subdir for each PR. It won't be trivial if even possible.