search

Katello / katello-client-bootstrap

Bootstrap Script for migrating systems to Foreman & Katello
GNU General Public License v2.0
52 stars 63 forks source link

allow fetching REX keys from the API #282

Closed evgeni closed 5 years ago

evgeni commented 5 years ago

this requires REX 1.6.7 or newer to be installed

includes #281

so far untested :)

fcami commented 5 years ago

Not tested either, but that's the right way to do it. LGTM!

evgeni commented 5 years ago

if this requires a specific version of REX, is there any way to check for that version and fail gracefully if not?

I can look into this. But the code will fail gracefully anyways, as in older versions there would be just no key listed, and then we don't add it. But we also don't tell the user that we didn't.

Doesn't the API require auth for most things? so wouldn't you have to ensure that the user has authenticated when using this capability?

Correct, this only works if you pass user/password. Want me to add a check for that?

ehelms commented 5 years ago

Needs an ole rebase!

evgeni commented 5 years ago

rebased