don't use json.loads to generate dicts

Katello / katello-client-bootstrap

Bootstrap Script for migrating systems to Foreman & Katello

GNU General Public License v2.0

52 stars 63 forks source link

don't use json.loads to generate dicts #288

Closed evgeni closed 5 years ago

evgeni commented 5 years ago

no idea why we did that to begin with, the result is a dict in either case, and this is more readable

this includes #287 because I'm too lazy to rebase it after #287 gets merged

sideangleside commented 5 years ago

Does passing build=false also prevent orchestration of the other proxy features (such as DNS, DHCP, or REALM)? If yes, this would address #171 as well.

evgeni commented 5 years ago

Does passing build=false also prevent orchestration of the other proxy features (such as DNS, DHCP, or REALM)? If yes, this would address #171 as well.

Most probably, yes. I have no setup to test that at the moment :(

Also, wrong PR ;)