search

Katello / katello-client-bootstrap

Bootstrap Script for migrating systems to Foreman & Katello
GNU General Public License v2.0
52 stars 63 forks source link

Fixes #29396 - Add support for katello-host-tools-tracer #327

Closed jturel closed 4 years ago

jturel commented 4 years ago

Adds --install-katello-host-tools-tracer option:

[SUCCESS], [2020-03-24 00:36:16], [/usr/bin/yum -y install katello-host-tools-tracer], completed successfully.
chris1984 commented 4 years ago

[test redmine]

jturel commented 4 years ago

@evgeni @sideangleside any feedback for me here?

evgeni commented 4 years ago

Can't this be solved via --install-packages? I'm hesitant adding another option :(

jturel commented 4 years ago

Can't this be solved via --install-packages? I'm hesitant adding another option :(

I'd like to advertise the utility - they probably don't know about it. We can remove --install-katello-agent soon so we're breaking even ;)

sideangleside commented 4 years ago

Actually, I see no reason why we'd not install it by default, and provide a --no-install-katello-host-tools-tracer option to negate the install if needed by the admin. I think we should aim to have a pretty robust 'out of box' experience. Packages/Configuration related to managing the client well that do not affect its security posture should IMHO be default.

So katello-host-tools and katello-host-tools-tracer are default. Deploying REX keys are opt-in.

--install-packages was moreso intended to install additional non-Katello/Foreman packages, and while it does work here, I almost think of it as optional.

jturel commented 4 years ago

Actually, I see no reason why we'd not install it by default, and provide a --no-install-katello-host-tools-tracer option to negate the install if needed by the admin. I think we should aim to have a pretty robust 'out of box' experience. Packages/Configuration related to managing the client well that do not affect its security posture should IMHO be default.

So katello-host-tools and katello-host-tools-tracer are default. Deploying REX keys are opt-in.

--install-packages was moreso intended to install additional non-Katello/Foreman packages, and while it does work here, I almost think of it as optional.

Agree on the robust out of box experience. Check out SAT-E-83 for why I don't think we should enable this by default yet. Since the decision on SAT-E-83 I've been looking at how to improve the performance, but it appears that it's tied up in how tracer itself works. I'm still learning about it. Before enabling it by default I think it needs to be fast all the time, but that's not the case at the moment.

jturel commented 4 years ago

@evgeni @sideangleside can we add this for now and post-next-release look at enabling tracer by default? Taking the feature out of tech preview in should see increased usage so we can address any underlying issues that have gone unnoticed. If all is well then I can definitely get behind enabling by default. Ping me if we need to hop on a call or something :)

chris1984 commented 4 years ago

ping @sideangleside @evgeni

evgeni commented 4 years ago

I just don't think bootstrap is the right place for it. Bootstraps purpose is to make it easy to attach an existing system to Foreman/Katello, once this is done, you can use whatever method available (rex, ansible, puppet, chef, katello agent shudder) to install additional packages.

If tracer is supposed to be out of tech preview now, make it easy to deploy it from the UI, done :)

sideangleside commented 4 years ago

I am OK with changing the defaults to deploy katello-host-tools-tracer. I am not OK with another CLI option for it.

If there are concerns with the robustness or performance of katello-host-tools-tracer, then (IMHO) we put this PR on hold until those concerns are addressed.

jturel commented 4 years ago

Thanks for the feedback. I do like the idea of making it easy to install via the UI. Closing this in favor of a solution along those lines.