search

Katsevich-Lab / sceptre

An R package for single-cell CRISPR screen data analysis emphasizing statistical rigor, massive scalability, and ease of use.
https://katsevich-lab.github.io/sceptre/
GNU General Public License v3.0
26 stars 8 forks source link

Using rbindlist instead of rbind #12

Closed 1onic closed 2 years ago

1onic commented 2 years ago

I found that using rbindlist(...) over rbind within the run_gRNA_gene_pair_analysis_at_scale() func (and also collect_results) had performance improvements for testing large amounts of pairs in speed and memory usage.

I also found this useful/reference: https://stackoverflow.com/questions/15673550/why-is-rbindlist-better-than-rbind

timothy-barry commented 2 years ago

Thanks for the suggestion. I think this is a good idea. I went ahead and made the update you suggested, adding data.table as a package dependency. I pushed the update to Github, so it should be available for download now.

I am closing this PR.

timothy-barry commented 2 years ago

Thanks for the suggestion. I think this is a good idea. I went ahead and made the update you suggested, adding data.table as a package dependency. I pushed the update to Github, so it should be available for download now.

I am closing this PR.