Support for Linux and SwiftPM by @AmmonP

Kelmatou / LeagueAPI

League of Legends API & Data Framework in Swift

MIT License

56 stars 13 forks source link

Support for Linux and SwiftPM by @AmmonP #18

Closed SKarajic closed 4 years ago

Kelmatou commented 4 years ago

Hi @SKarajic!

I reviewed @AmmonP's improvement and I like it. The pipeline is failing because the Xcode project file doesn't reference the new LAPIImage.swift

I'll update the code to make it work on Apple's platforms as well

Thank you

SKarajic commented 4 years ago

Yeah, would be great if it could be adjusted. This change would also allow for server-side development. I noticed @AmmonP's fork, but noticed that he didn't create a PR, so i did instead. If i notice anything not working on server-side, i'll happily create some changes in order to make it work. 👍🏻

Kelmatou commented 4 years ago

I'd appreciate any feedback on server-side usage!

I've changed the PR destination to a specific branch. I'll fix the compile errors and I will merge it into master Thanks @SKarajic @AmmonP!

AmmonP commented 4 years ago

If you need me to look at anything let me know, I was just originally making rudimentary adjustments to get it to compile. My biggest concern was to avoid breaking the existing API definitions.