Kenan2000 / BrightNights-Structured-Kenan-Modpack

Kenan's personal modpack for Bright Nights version of CDDA by Coolcthulhu
94 stars 36 forks source link

[Reapermod_Shinigami] Shinigami Song martial art missing "melee_allowed": true tags #122

Closed Usokitsuki closed 2 years ago

Usokitsuki commented 2 years ago

When wielding scythe (any scythe that is listed as a Shinigami Song compatible weapon) with sufficient melee skills neither static buffs, nor melee techniques are triggering due to missing "melee_allowed": true field, as seen by missing static buffs in the character menu when wielding the weapon.

image

image

image

Solution Add "melee_allowed": true fields to each instance of buffs and techniques in the mods martialarts.json, techniques.json, e.g. changing:

      {
        "id": "shinigami_staticbuff1",
        "name": "Winds of the End",
        "description": "Bonus to hit increase when a scythe is equipped.",
        "max_stacks": 1,
        "flat_bonuses": [ { "stat": "hit", "scale": 1.0 } ]
      },

to

      {
        "id": "shinigami_staticbuff1",
        "name": "Winds of the End",
        "description": "Bonus to hit increase when a scythe is equipped.",
        "max_stacks": 1,
    "melee_allowed": true,
        "flat_bonuses": [ { "stat": "hit", "scale": 1.0 } ]
      },

and

    "type": "technique",
    "id": "tec_shinigami_crit",
    "name": "Critical Shinigami Attack",
    "skill_requirements": [ { "name": "melee", "level": 3 } ],
    "crit_tec": true,
    "flat_bonuses": [ { "stat": "arpen", "type": "cut", "scale": 10 } ],
    "mult_bonuses": [ { "stat": "damage", "type": "cut", "scale": 1.5 } ],
    "messages": [ "You critical attack %s", "<npcname> critical attacks %s" ]
  },

to

    "type": "technique",
    "id": "tec_shinigami_crit",
    "name": "Critical Shinigami Attack",
    "skill_requirements": [ { "name": "melee", "level": 3 } ],
    "melee_allowed": true,
    "crit_tec": true,
    "flat_bonuses": [ { "stat": "arpen", "type": "cut", "scale": 10 } ],
    "mult_bonuses": [ { "stat": "damage", "type": "cut", "scale": 1.5 } ],
    "messages": [ "You critical attack %s", "<npcname> critical attacks %s" ]
  },

etc.

Kenan2000 commented 2 years ago

@Usokitsuki Hopefully fixed in this update as well