Kesomannen / gale

Lightweight Thunderstore client
GNU General Public License v3.0
25 stars 3 forks source link

Kitchen Sink of Issues and Suggestions :) #2

Closed Test-Account666 closed 3 weeks ago

Test-Account666 commented 1 month ago

Hello!

You mod manager feels really good and I'd like to see it grow.

I do have some issues/suggestions for you though ^^

Issues:

Suggestions:

waste

It could look like this: example

Kesomannen commented 1 month ago

Thanks for the suggestions! The first issue is probably on your end or on the rust crate's end (https://crates.io/crates/open). The other two I have fixed and trying to fix some other config parsing issues. For the suggestions:

  1. Planned and pretty quick to add.
  2. Not too sure about this one, I would have to make some bigger code changes and doesnt feel like it happens that often?
  3. Yeah should definitely add this
  4. Same for this
  5. I also thought about this, maybe I'll move it to the bottom. I was close to removing it, but I couldnt figure out how to redirect to the mod list automatically (since it isn't at the index route) (I'm a bit new to web development).
  6. The right-click menu is from the webview itself, so I dont think I can control that. Will look into it though
  7. Maybe I'll change this to a dialog inside of the app. I thought a native dialog was fitting because it's a pretty consequential action. Also was just easier to implement xD
  8. I do agree on this, but sounds a bit too complicated for now. It has to do a fetch request to get the README, which could look a bit odd if you're switching between mods (having a spinner appear and disappear over and over). Also it's a bit tough on the implementation side, and I have to account for when the description is too long or the window too small. Maybe some more experienced web dev could pull it off, but I'm probably leaving it like it is for now.
  9. This is also planned, I just have to look into how exactly r2modman/thunderstore do it.
Test-Account666 commented 1 month ago
  1. Not too sure about this one, I would have to make some bigger code changes and doesnt feel like it happens that often?

Yeah... It usually doesn't occur.

  1. I also thought about this, maybe I'll move it to the bottom. I was close to removing it, but I couldnt figure out how to redirect to the mod list automatically (since it isn't at the index route) (I'm a bit new to web development).

I think moving it to the bottom would be nice.

Maybe also switch the position of the "Browse mods" and "Manage profile" button? I think that would be more intuitive. Could just be my muscle memory speaking though...

  1. The right-click menu is from the webview itself, so I dont think I can control that. Will look into it though

You should at least be able to block it and make your own. Not sure how much work that is though...

  1. Maybe I'll change this to a dialog inside of the app. I thought a native dialog was fitting because it's a pretty consequential action. Also was just easier to implement xD

I personally hate native dialogs, since they never seem to act as they should xd

But I understand that you chose the easier route xD

  1. I do agree on this, but sounds a bit too complicated for now. [...] Maybe some more experienced web dev could pull it off, but I'm probably leaving it like it is for now.

Well, I hope you can implement this at some point :)

  1. This is also planned, I just have to look into how exactly r2modman/thunderstore do it.

Pretty sure they just rename the dll file to <modname>.dll.old and call it a day 🤔

Test-Account666 commented 1 month ago

Oh... There's one more bug I'd like to mention.

For some reason I can always resize the application.

Even when maximized.

This sometimes leads to me accidentally resizing the window instead of moving it to my other monitor

Test-Account666 commented 1 month ago

Two new suggestions:

Test-Account666 commented 1 month ago

Another one:

That would ensure that the user doesn't accidentally update mods

Test-Account666 commented 1 month ago

A new issue discovered:

When editing some configs, I noticed that some of them are too short.

Well, turns out Gale hides some entries for some reason

Test-Account666 commented 1 month ago

Hope you're not overwhelmed 😅

Failed to execute 'query_mods_in_profile' - Package with id c59bda38-e6de-4483-87b7-ecc34b490760 not found.

If that happens, I can no longer see any mods in my profile

Test-Account666 commented 1 month ago

Suggestions Time! :)

This is crucial, if you have a mod targeting another as dependency, but you want to use a fork of said dependency

Kesomannen commented 1 month ago

For some reason I can always resize the application.

Doesn't for me on Windows, so probably something your desktop environment 🤷

Don't show deprecated mods by default (Or make it toggleable)

It is already toggleable in the Filters dropdown. I do plan to improve on the filtering later, will probably make something similar to how they do it on thunderstore.io

Some config entries are not shown in the config editor

Not sure why this would be happening, could you share more more details?

Failed to execute 'query_mods_in_profile' - Package with id c59bda38-e6de-4483-87b7-ecc34b490760 not found. If that happens, I can no longer see any mods in my profile

This is due to going to the profile page while mods are still being fetched. I've thought about some fixes, but havent got to actually implementing any yet.

Allow uninstalling of dependencies without uninstalling dependents

This is already done for 0.3.0

Kesomannen commented 1 month ago

I think everything here is actually implemented by now lol