search

KevinnZou / compose-webview-multiplatform

WebView for JetBrains Compose Multiplatform
https://kevinnzou.github.io/compose-webview-multiplatform/
Apache License 2.0
305 stars 39 forks source link

Consider wasmJS(WebAssembly) support ? #116

Open vickyleu opened 2 months ago

vickyleu commented 2 months ago

Can it be achieved through iframe or other methods? or webview for webassembly?

KevinnZou commented 2 months ago

@vickyleu Thank you for your suggestion! I currently have no plans to support WASM, as it is not my area of expertise and I am focused on mobile development. However, I would be more than welcome to consider a pull request from someone who is willing to contribute!

jershell commented 1 month ago

JS/WASM requires iframe. We did it, but iframe always on the top of the canvas. If is okay, we could make a PR

KevinnZou commented 1 month ago

@jershell Thanks for your suggestion! You are welcomed to make a PR!

but iframe always on the top of the canvas. Is the bug related to Compose Multiplatform or the Platform feature? If the issue is related to CMP, I believe they will resolve it in the future, so it should not pose a significant problem.

Xerosigma commented 1 month ago

JS/WASM requires iframe. We did it, but iframe always on the top of the canvas. If is okay, we could make a PR

@jershell did you open a PR for this already?

Xerosigma commented 1 month ago

WIP: https://github.com/KevinnZou/compose-webview-multiplatform/pull/133

KevinnZou commented 3 days ago

@jershell @Xerosigma Hi guys, I have submitted a PR that made an empty implementation for WASM/JS. You are welcome to implement the specific functionality for WASM based on this PR. Please let me know if you have any suggestions! Thanks!