KewBridge / specimens2illustrations

1 stars 1 forks source link

Not all usable figures are pulled from the articles #24

Open ErenKarabey opened 12 months ago

ErenKarabey commented 12 months ago

In the 3rd article (Knapp S, Sagona E, Carbonell AKZ, Chiarini F (2017) ), no photograph of figures are pulled. phytokeys.84.12695 is empty except for the species-description.txt

<tp:treatment-sec sec-type="material" id="SECID0EJPCK">
<title>Type.</title>
<p>
Based on
<italic>
<tp:taxon-name>
<tp:taxon-name-part taxon-name-part-type="genus" reg="Solanum">Solanum</tp:taxon-name-part>
<tp:taxon-name-part taxon-name-part-type="species" reg="carolinense">carolinense</tp:taxon-name-part>
</tp:taxon-name>
</italic>
Mill.
</p>
<fig id="F10" position="float" orientation="portrait">
...
</fig>
<fig id="F11" position="float" orientation="portrait">
<object-id content-type="doi">10.3897/phytokeys.84.12695.figure11</object-id>
<object-id content-type="zenodo_dep_id">992853</object-id>
<object-id content-type="arpha">AF9C0C4B-44AD-55DB-8EE9-50AFDAE8E811</object-id>
<label>Figure 11.</label>
<caption>
<p>
Lectotype of
<italic>
<tp:taxon-name>
<tp:taxon-name-part taxon-name-part-type="genus" reg="Solanum">S.</tp:taxon-name-part>
<tp:taxon-name-part taxon-name-part-type="species" reg="tridynamum">tridynamum</tp:taxon-name-part>
</tp:taxon-name>
</italic>
Dunal. Unpublished drawing by T.F. Node-Véran (1773–1852) based on an illustration of Sessé and Mociño (MPU310713). Reproduced with permission of the Université de Montpellier – Herbier MPU (Service de Patrimoine Historique); copyright Université de Montpellier – Herbier MPU (SPH).
</p>
</caption>
<graphic xlink:href="phytokeys-84-001_article-12695__-g011.jpg" position="float" orientation="portrait" xlink:type="simple" id="oo_148809.jpg">
<uri content-type="original_file">https://binary.pensoft.net/fig/148809</uri>
</graphic>
</fig>
<!-- PageBreak -->
</tp:treatment-sec>

https://github.com/KewBridge/specimens2illustrations/blob/a72901971abc3e17c742ebe59dad48dffa1cd8ca/xml2illustrationdata.py#L15-L17 is not enough to pull some figures.

ErenKarabey commented 12 months ago

Check whether all unwanted figures are distribution tagged