KeyWorksRW / wxUiEditor

RAD tool used to create and maintain wxWidgets UI elements.
Apache License 2.0
64 stars 7 forks source link

Switch to C sources for plutovg library #1455

Closed Randalphwa closed 6 months ago

Randalphwa commented 6 months ago

See PR for description of why

This PR changes the wxWidgets portion of the build to use the C sources for plutovg (sub module for LunaSVG) instead of the C++ sources. This is done to match the way the LunaSVG sources will be integrated into the official wxWidgets 3.3 sources.

While I prefer the C++ sources, the PR with these sources submitted to the LunaSVG project was rejected. The reasoning is that while changes to the underlying plutovg library are rare (in fact, they may never change again), using C++ sources would complicate updating LunaSVG should plutovg ever change.

I can't justify the C++ sources when submitting the LunaSVG PR to wxWidgets, so it makes sense to use the C sources here as well.

Note to future self -- we may have to use the C++ sources if we ever provide the option to the user to display SVG using NanoSVG instead of LunaSVG.