search

KhronosGroup / SPIRV-Headers

SPIRV-Headers
Other
273 stars 260 forks source link

Migrate extension headers from SPIRV-Tools to SPIRV-Headers #137

Open ben-clayton opened 4 years ago

ben-clayton commented 4 years ago

SPIRV-Tools contains the following SPIR-V instruction extension definition files:

SPIR-V Tools uses these to produce header files into an intermediate directory as part of the build. Projects that wish to make use of these will need to either fetch these out of the intermediate directory, or re-generate them itself (both approaches requiring custom build rules).

It would be far more convenient if these headers were pre-built and were part of SPIRV-Headers, much like GLSL.std.450.h.

c0d1f1ed commented 4 years ago

https://swiftshader-review.googlesource.com/c/SwiftShader/+/43428 was landed as a workaround in SwiftShader. We can remove that section from our CMakeLists.txt once this gets addressed in SPIRV-Headers.

c0d1f1ed commented 4 years ago

This appears to have been fixed by @dneto0 as part of #143